Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lightdm: fix pam rules #67917

Merged
merged 1 commit into from Sep 6, 2019
Merged

nixos/lightdm: fix pam rules #67917

merged 1 commit into from Sep 6, 2019

Conversation

worldofpeace
Copy link
Contributor

The work "fix" is pretty subjective since this
is literally a translation of what's done in the
GDM module and adjustments based of
looking at Arch Linux's configuration

Motivation for this change

Fixes #64259

Any user of lightdm and gnome-keyring should now have the keyring created and unlocked on login. My PAM understanding is not completely there (literally read this) but I have been using this for a while.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added this to In progress in Pantheon via automation Sep 2, 2019
@worldofpeace
Copy link
Contributor Author

Requesting your review @e-user since this is a partial "borrowing" of your work on GDM.

outergod
outergod approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@outergod outergod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it right now, but looks about right. Everything works for you, doesn't it?

@worldofpeace
Copy link
Contributor Author

Everything works for you, doesn't it?

Yeah 😁️, I just wanted good confirmation since it can be pretty important.

@worldofpeace
nixos/lightdm: fix pam rules
0c60254 
Rules are a translation of what's done in the
GDM module and adjustments based of looking at
Arch Linux's configuration and upstream's.

A side effect of this change is that gnome-keyring
and kwallet modules should work as expected when in-
cluded.

Fixes NixOS#64259 NixOS#62045
@worldofpeace worldofpeace merged commit 4e89375 into NixOS:master Sep 6, 2019
Pantheon automation moved this from In progress to Done Sep 6, 2019
@worldofpeace worldofpeace deleted the lightdm-pam-gnome-keyring branch September 6, 2019 22:50
@worldofpeace worldofpeace mentioned this pull request Sep 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outergod outergod outergod approved these changes

@disassembler disassembler disassembler approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
Pantheon
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkManager: Can't connect to VPN
3 participants
@worldofpeace @outergod @disassembler