Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for js-unknown-ghcjs #67920

Merged
merged 4 commits into from Sep 2, 2019
Merged

Add support for js-unknown-ghcjs #67920

merged 4 commits into from Sep 2, 2019

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Sep 2, 2019 •
edited

Motivation for this change

Forward port of #67359.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

angerman and others added 2 commits September 2, 2019 01:27
@angerman @Ericson2314
Add support for js-unknown-ghcjs
446f8c8 
This adds enough logic to nixpkgs to support the `js-unknown-ghcjs` triple.
@Ericson2314
Merge remote-tracking branch 'upstream/master' into feature/js-unknow…
c33d80c 
…n-ghcjs
@Ericson2314 Ericson2314 changed the title Feature/js unknown ghcjs Code Issues 3,163 Pull requests 1,290 Projects 16 Security Insights Add support for js-unknown-ghcjs Sep 2, 2019
@Ericson2314 Ericson2314 changed the title Code Issues 3,163 Pull requests 1,290 Projects 16 Security Insights Add support for js-unknown-ghcjs Add support for js-unknown-ghcjs Sep 2, 2019
@ofborg ofborg bot added the 6.topic: stdenv Standard environment label Sep 2, 2019
@Ericson2314 Ericson2314 merged commit d2d107c into NixOS:master Sep 2, 2019
@Ericson2314 Ericson2314 deleted the feature/js-unknown-ghcjs branch September 2, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @angerman