Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.arc-menu: init at 31 #67964

Merged
merged 1 commit into from Sep 3, 2019
Merged

gnomeExtensions.arc-menu: init at 31 #67964

merged 1 commit into from Sep 3, 2019

Conversation

dkabot
Copy link
Member

@dkabot dkabot commented Sep 2, 2019

Motivation for this change

This GNOME extension is often used alongside dash-to-panel, and much like appmenu requires a specific patch to work, making it more of a pain than others to add as an overlay.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ryantm ryantm requested a review from jtojnar September 2, 2019 22:19
@jtojnar
Copy link
Contributor

jtojnar commented Sep 3, 2019

Thank you.

Seems to work fine:

Screenshot from 2019-09-03 04-24-55

@jtojnar jtojnar merged commit 4a220b6 into NixOS:master Sep 3, 2019
@jtojnar
Copy link
Contributor

jtojnar commented Sep 3, 2019

Weirdly it shows Firefox is pinned, even though it is not installed in the VM. But that is probably an upstream bug.

@dkabot
Copy link
Member Author

dkabot commented Sep 3, 2019

Been using it on my personal system for the past ~day, but always good to hear that it's not magically failing.

Re: Firefox, I'd agree that's probably an upstream bug; I'm pretty sure the favorites list preset is just hardcoded.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 3, 2019

Yeah, it is good to let someone else test it to reduce the chance that it is only working on your computer due to some thing installed globally. Unfortunately, the fact that environment variables are inherited by child processes makes the isolation hard.

I also like to click through the extension with journaltl -xeaf running in the terminal and checking for any errors. Here I only saw

JS WARNING: [/run/current-system/sw/share/gnome-shell/extensions/arc-menu@linxgem33.com/controller.js 46]: reference to undefined property "currentMonitorIndex"

when it was enabled and

JS ERROR: Error: No signal connection 0 found
                                            _disconnect@resource:///org/gnome/gjs/modules/signals.js:78:11
                                            _onDestroy@/run/current-system/sw/share/gnome-shell/extensions/arc-menu@linxgem33.com/menu.js:284:13
                                            callParent@/run/current-system/sw/share/gnome-shell/extensions/arc-menu@linxgem33.com/utils.js line 74 > eval:1:180
                                            _onDestroy@/run/current-system/sw/share/gnome-shell/extensions/arc-menu@linxgem33.com/menu.js:325:13
                                            _disableButton@/run/current-system/sw/share/gnome-shell/extensions/arc-menu@linxgem33.com/controller.js:355:9
                                            destroy@/run/current-system/sw/share/gnome-shell/extensions/arc-menu@linxgem33.com/controller.js:368:13
                                            _disableButton@/run/current-system/sw/share/gnome-shell/extensions/arc-menu@linxgem33.com/extension.js:165:5
                                            disable/<@/run/current-system/sw/share/gnome-shell/extensions/arc-menu@linxgem33.com/extension.js:90:39
                                            disable@/run/current-system/sw/share/gnome-shell/extensions/arc-menu@linxgem33.com/extension.js:90:5
                                            disableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:79:9
                                            onEnabledExtensionsChanged/<@resource:///org/gnome/shell/ui/extensionSystem.js:293:9
                                            onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:290:5

when it was disabled. Both should probably be reported upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dkabot @jtojnar @Janik-Haag