Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: improve content #67962

Merged
merged 1 commit into from Sep 8, 2019
Merged

README.md: improve content #67962

merged 1 commit into from Sep 8, 2019

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Sep 2, 2019

Motivation for this change

I was initially motivated by @zimbatm's comment on my RFC. Also, the README file is prominent documentation and marketing that new users see and it was previously pretty light on content.

I realize some of this is duplicated from the NixOS homepage, but I think it is good to have information here too.

Rendered link

Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text includes everything that I could think about and is well written. The NixOS homepage is the general public landing page and this is the developer's landing page. And this does a really great job at it. 💯

@worldofpeace worldofpeace self-requested a review September 3, 2019 02:30
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
nlewo
nlewo previously requested changes Sep 3, 2019
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@worldofpeace
Copy link
Contributor

@ryantm, this looks really really good 😄.

It's been a bit, I'm ready to merge as is. Let's go 🏁️

@worldofpeace worldofpeace merged commit 8bc72d1 into NixOS:master Sep 8, 2019
@ryantm ryantm deleted the readme branch August 8, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants