Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miller: 5.4.0 -> 5.5.0 #67963

Merged
merged 2 commits into from Sep 2, 2019
Merged

miller: 5.4.0 -> 5.5.0 #67963

merged 2 commits into from Sep 2, 2019

Conversation

mstarzyk
Copy link
Contributor

@mstarzyk mstarzyk commented Sep 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

ryantm
ryantm requested changes Sep 2, 2019
View reviewed changes
pkgs/tools/text/miller/default.nix Outdated Show resolved Hide resolved
ryantm
ryantm approved these changes Sep 2, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • built on NixOS
  • nix-review passed
  • tested basic help messages of all binaries
  • leaf package
  • checked OfBorg all green

@ryantm ryantm merged commit 2e5fd3a into NixOS:master Sep 2, 2019
@mstarzyk mstarzyk deleted the miller-5.5.0 branch September 3, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mstarzyk @ryantm