Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{icestorm,nextpnr}: fixes #67961

Merged
merged 3 commits into from Sep 2, 2019
Merged

{icestorm,nextpnr}: fixes #67961

merged 3 commits into from Sep 2, 2019

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Sep 2, 2019

Motivation for this change

This fixes YosysHQ/icestorm#234 for me, and should hopefully also fix #67898 (it at least builds successfully, but unfortunately I don't have a 10.14 desktop to test that the GUI works on).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @thoughtpolice

@ofborg ofborg bot requested a review from thoughtpolice September 2, 2019 20:06
@thoughtpolice
Copy link
Member

@GrahamcOfBorg build icestorm nextpnr

@thoughtpolice thoughtpolice self-assigned this Sep 2, 2019
@thoughtpolice
Copy link
Member

The builds timed out of course, but we know they work fine on x86_64, and it fixed the compile failure on Darwin, so let's go!

@thoughtpolice thoughtpolice merged commit 12ae045 into NixOS:master Sep 2, 2019
@emilazy emilazy deleted the foss-eda-fixes branch September 2, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees

@thoughtpolice thoughtpolice

Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nextpnr does not build on Darwin Crashes after (successfully) programming
2 participants
@emilazy @thoughtpolice