Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.cherrypy: fix tests after upgrade to pytest5 #68001

Merged
merged 1 commit into from Sep 3, 2019

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Sep 3, 2019

Motivation for this change

Fix cherrypy python3 build after pytest5 upgrade broke the tests: b3ddab8
See cherrypy/cherrypy#1791 for reference.

@GrahamcOfBorg build python3Packages.cherrypy

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@FRidh
Copy link
Member

FRidh commented Sep 3, 2019

@GrahamcOfBorg build python3Packages.cherrypy

@johanot johanot mentioned this pull request Sep 3, 2019
10 tasks
@srhb
Copy link
Contributor

srhb commented Sep 3, 2019

Looks good!

@srhb srhb merged commit ce8cd5f into NixOS:master Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants