Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add onboard to Pantheon #67915

Merged
merged 4 commits into from Sep 2, 2019
Merged

Add onboard to Pantheon #67915

merged 4 commits into from Sep 2, 2019

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Sep 2, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
onboard: cleanups
896da41 
* workaround NixOS#56943
* fix xdg autostart installed to site-packages
* delete ubuntu icons
@worldofpeace
pantheon.elementary-session-settings: add onboard autostart
5c04758
@worldofpeace
pantheon.switchboard-plug-a11y: hardcode path to onboard-settings
81a1bd6
@worldofpeace
nixos/pantheon: add onboard
b1326ff 
It's used as an on-screen keyboard.
Hopefully in future they can ship their native app [0]

[0]: https://github.com/elementary/keyboard
@ofborg ofborg bot requested a review from johnramsden September 2, 2019 04:28
@worldofpeace worldofpeace added this to In progress in Pantheon via automation Sep 2, 2019
@worldofpeace worldofpeace merged commit 74b42e2 into NixOS:master Sep 2, 2019
Pantheon automation moved this from In progress to Done Sep 2, 2019
@worldofpeace worldofpeace deleted the pantheon-onboard branch September 2, 2019 04:39
@worldofpeace worldofpeace mentioned this pull request Sep 2, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnramsden johnramsden Awaiting requested review from johnramsden

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
Pantheon
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace