Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages: unbreak cachix build #67914

Merged
merged 1 commit into from Sep 3, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Sep 2, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor Author

marsam commented Sep 2, 2019

@GrahamcOfBorg build cachix

@cdepillabout
Copy link
Member

@marsam I believe the nixpkgs haskell maintainers generally don't want PRs to touch the pkgs/development/haskell-modules/hackage-packages.nix file. Could you remove your changes from this file?

(#67438 (comment))

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 2, 2019

I believe the nixpkgs haskell maintainers generally don't want PRs to touch the pkgs/development/haskell-modules/hackage-packages.nix file.

Can confirm. See #67772.

@marsam
Copy link
Contributor Author

marsam commented Sep 2, 2019

@cdepillabout, @rnhmjoj thanks for reviewing. I've addressed your comments.

Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tried removing the broken attribute and it builds.

@cdepillabout
Copy link
Member

cc @peti @infinisil

@infinisil infinisil merged commit 107d78b into NixOS:haskell-updates Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants