Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofi: fix rofi-theme-selector by setting $XDG_DATA_DIRS #67846

Merged
merged 1 commit into from Sep 2, 2019
Merged

rofi: fix rofi-theme-selector by setting $XDG_DATA_DIRS #67846

merged 1 commit into from Sep 2, 2019

Conversation

astro
Copy link
Contributor

@astro astro commented Aug 31, 2019

Motivation for this change

rofi-theme-selector was not able to find rofi themes. $XDG_DATA_DIRS must be set which is evaluated by this script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mbakke @Ma27

@ofborg ofborg bot requested a review from Ma27 August 31, 2019 19:44
Ma27
Ma27 reviewed Sep 1, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue is fixed by this patch, please take a look at my comment, apart from that, this seems mergable 👍

pkgs/applications/misc/rofi/default.nix Outdated Show resolved Hide resolved
@astro
Copy link
Contributor Author

astro commented Sep 2, 2019

Thank you for the review. Fixed, rebased, and pushed.

@ofborg ofborg bot requested a review from Ma27 September 2, 2019 23:25
@Ma27 Ma27 merged commit 14c48f7 into NixOS:master Sep 2, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 2, 2019

@astro thanks!

@astro astro deleted the fix-rofi-theme-selector branch September 3, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@astro @Ma27 @worldofpeace