Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome3.gvfs: fix eval with allowAliases = false #67935

Merged
merged 5 commits into from Sep 3, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 2, 2019

And other various no-op fixes.

Not needed by anything and dropping it will allow us to clean up the expression.

Changed to an alias as that is what it was in the first place.
It will make the expression and calls nicer.
Since we moved gsettings-desktop-schemas to top-level, gnome3.glib-networking was the same as glib-networking.
We could try to make the top-level variant not depend on gsettings-desktop-schemas again but that is probably
pointless, as the dependency is rather small compared to things like libproxy. Instead, we will just drop
the package in gnome3 attr set and always rely on the top-level expression.
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@worldofpeace worldofpeace merged commit 0c52651 into NixOS:master Sep 3, 2019
@jtojnar jtojnar deleted the gnome-fixes branch September 3, 2019 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants