Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pikepdf: 1.1.0 -> 1.6.2, pybind11: 2.2.4 -> 2.3.0 #67853

Merged
merged 2 commits into from Sep 1, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Aug 31, 2019

Motivation for this change

This fixes #67850.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested ocrmypdf on NixOS x86_64.

Notify maintainers

cc @yuriaisaka @Kiwi @FRidh

pikepdf wants a newer pybind11.
pikepdf's tests work with the nixpkgs versions of pytest, attrs, and
hypothesis. I skipped bumping these to avoid mass rebuilds.

This fixes NixOS#67850.
@ivan ivan requested a review from FRidh as a code owner August 31, 2019 22:25
@ivan
Copy link
Member Author

ivan commented Aug 31, 2019

@GrahamcOfBorg build python3Packages.pikepdf ocrmypdf

pybind11 users:

@GrahamcOfBorg build python3Packages.accupy
@GrahamcOfBorg build pythonPackages.pyopencl python3Packages.pyopencl
@GrahamcOfBorg build pythonPackages.fasttext python3Packages.fasttext
@GrahamcOfBorg build pythonPackages.pyfma python3Packages.pyfma
@GrahamcOfBorg build pythonPackages.pyamg python3Packages.pyamg
@GrahamcOfBorg build caffe2

@@ -22,12 +22,12 @@

buildPythonPackage rec {
pname = "pikepdf";
version = "1.1.0";
version = "1.6.2";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wondering if the other changes that landed with this were out of date...

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all checks were ✔️.

@worldofpeace worldofpeace merged commit 3104cb2 into NixOS:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pikepdf build fails trying to download pytest from pypi
2 participants