filebot: init at 4.8.5 #67849
Closed
filebot: init at 4.8.5 #67849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build filebot |
symphorien
reviewed
Sep 1, 2019
|
@symphorien Addressed your comments, PTAL |
symphorien
reviewed
Sep 3, 2019
|
|
||
| nativeBuildInputs = [ makeWrapper autoPatchelfHook | ||
| # The following are lib dependencies for autoPatchelfHook to work. | ||
| stdenv.cc.cc.lib zlib libzen libmediainfo curlWithGnuTls libmms glib ]; |
There was a problem hiding this comment.
These should be buildInputs (runtime dependencies), not nativeBuildInputs (build dependencies).
symphorien
reviewed
Sep 3, 2019
| # The following are lib dependencies for autoPatchelfHook to work. | ||
| stdenv.cc.cc.lib zlib libzen libmediainfo curlWithGnuTls libmms glib ]; | ||
|
|
||
| buildPhase = ''''; |
There was a problem hiding this comment.
Suggested change
| buildPhase = ''''; | |
| dontBuild = true; |
symphorien
reviewed
Sep 3, 2019
| ln -s $out/opt/filebot.sh $out/bin/filebot | ||
| ''; | ||
|
|
||
| patchPhase = ''''; |
|
ping @gleber, any update? |
|
OBE. See above PR ^^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a non-free application to rename downloaded media files as per internet databases of medias.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @