Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomacs: really use Qt mkDerivation #67886

Merged
merged 1 commit into from Sep 1, 2019
Merged

nomacs: really use Qt mkDerivation #67886

merged 1 commit into from Sep 1, 2019

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Sep 1, 2019

Motivation for this change

It looks like a force push in #67767 went wrong, so here is the correct version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace

@FRidh FRidh merged commit 9334ce1 into NixOS:master Sep 1, 2019
@B4dM4n B4dM4n deleted the nomacs-wrap-qt branch September 1, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@B4dM4n @FRidh