onboard: Fix gobject-introspection #67884
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
reviewed
Sep 1, 2019
| @@ -91,6 +91,7 @@ in python3.pkgs.buildPythonApplication rec { | |||
| wrapGAppsHook | |||
| xorg.libXtst | |||
| xorg.libxkbfile | |||
| gobject-introspection # Temporary fix, see https://github.com/NixOS/nixpkgs/issues/56943 | |||
There was a problem hiding this comment.
Suggested change
| gobject-introspection # Temporary fix, see https://github.com/NixOS/nixpkgs/issues/56943 |
And use
strictDeps = false;
with the comment.
There was a problem hiding this comment.
@worldofpeace is it better to remove strictDeps vs listing twice? If so, why?
There was a problem hiding this comment.
The issue is actually triggered preventing the setup hook from being ran because of strictDeps being used #56943 (comment).
There was a problem hiding this comment.
So this will be the best work around until the eventual issue is fixed.
There was a problem hiding this comment.
Correct, as python packages enabled strictDeps this was the regression that followed for gobject-introspection using applications.
johnramsden
suggested changes
Sep 2, 2019
|
I've fixed this in #67915 along with some other issues with onboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#56943
Onboard was not working under
xmonad(AFAIK it works fine undergnome).Fixed as per ticket #56943 by adding
gobject-introspectiontobuildInputs(it's already innativeBuildInputs.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @johnramsden