Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mhonarc: 2.6.18 -> 2.6.19, fix build, and cleanup #67854

Merged
merged 4 commits into from Sep 7, 2019
Merged

mhonarc: 2.6.18 -> 2.6.19, fix build, and cleanup #67854

merged 4 commits into from Sep 7, 2019

Conversation

alyssais
Copy link
Member

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323

@alyssais
perlPackages.MHonArc: 2.6.18 -> 2.6.19
224f145 
Needs a patch before it'll run, but it didn't run before and might as
well be updated before it's patched.
@alyssais
perlPackages.MHonArc: fix build
37b81c9
@alyssais
perlPackages.MHonArc: update metadata and style
4523698
@alyssais
mhonarc: add top-level path to perlPackages.MHonArc
9268e5d 
Since MHonArc is a program, not a library, it makes sense to expose it
on the top level, in lowercase, like other programs.
@alyssais alyssais added the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 31, 2019
@risicle
Copy link
Contributor

risicle commented Sep 7, 2019

nix-review is happy on macos 10.13, but I don't know enough about the package to test it fully.

@alyssais alyssais merged commit f8fd80b into NixOS:master Sep 7, 2019
@alyssais alyssais deleted the mhonarc branch September 7, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @risicle