New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-notes: mention restricted SysRq key combinations #67840
Conversation
This was missing from NixOS#66482.
|
||
This also configures the kernel to pass coredumps to <literal>systemd-coredump</literal>. | ||
This also configures the kernel to pass coredumps to <literal>systemd-coredump</literal>, | ||
and restricts the SysRq key combinations to the sync command only. | ||
These sysctl snippets can be found in <literal>/etc/sysctl.d/50-*.conf</literal>, | ||
and overridden via <link linkend="opt-boot.kernel.sysctl">boot.kernel.sysctl</link> | ||
(which will place the parameters in <literal>/etc/sysctl.d/60-nixos.conf</literal>). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could also explain here how to get the old setting back. Like the "to stick to the old behavior ... set boot.kernel.sysctl..." sentence right below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already explain how to override values set in those snippets.
Listing each of those individually, with instructions on how to get to the old value would increase this paragraph quite a bit, and I'd like to keep it terse.
I think it's enough pointing at it, if someone stumbles over it, they'll likely look up the snippet file and think about what values to set anyways.
|
||
This also configures the kernel to pass coredumps to <literal>systemd-coredump</literal>. | ||
This also configures the kernel to pass coredumps to <literal>systemd-coredump</literal>, | ||
and restricts the SysRq key combinations to the sync command only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by looking at https://www.kernel.org/doc/html/latest/admin-guide/sysrq.html I could see the other sysrg functions which weren't enable sync command
so I knew which one's were disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This was missing from #66482.
Motivation for this change
#66482 (comment)
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @gebner