Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixosTests.systemd: only run sysctl test on x86_64 #67837

Closed
wants to merge 1 commit into from
Closed

nixosTests.systemd: only run sysctl test on x86_64 #67837

wants to merge 1 commit into from

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 31, 2019

it seems CONFIG_NET_SCHED isn't included in arm/aarch64 defconfig (yet?),
so this test would fail on these architectures.

Motivation for this change

nixosTests.systemd is broken on aarch64.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @aszlig @disassembler, followup of discussion in #67798.

@flokli
nixosTests.systemd: only run sysctl test on x86_64
9c287c1 
it seems CONFIG_NET_SCHED isn't included in arm/aarch64 defconfig (yet?),
so this test would fail on these architectures.
@flokli
Copy link
Contributor Author

flokli commented Aug 31, 2019

@GrahamcOfBorg test systemd

@flokli
Copy link
Contributor Author

flokli commented Sep 1, 2019

closing in favour of #67855.

@flokli flokli closed this Sep 1, 2019
@flokli flokli deleted the nixosTests.systemd-fq_codel branch September 1, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aszlig aszlig Awaiting requested review from aszlig

@andir andir Awaiting requested review from andir

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@flokli