Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cryptpad: 2.25.0 -> 3.0.0 #67838

Merged
merged 1 commit into from Aug 31, 2019
Merged

cryptpad: 2.25.0 -> 3.0.0 #67838

merged 1 commit into from Aug 31, 2019

Conversation

blitz
Copy link
Contributor

@blitz blitz commented Aug 31, 2019

Motivation for this change

Update to latest stable version with (undisclosed) security fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @zimbatm

@zimbatm
Copy link
Member

zimbatm commented Aug 31, 2019

@GrahamcOfBorg build cryptpad

@blitz
Copy link
Contributor Author

blitz commented Aug 31, 2019

@zimbatm Is the reason why bower-packages.nix has to manually edited to include a second bootstrap dependency a cryptpad or a bower2nix issue? For the former, I could open a cryptpad issue, but unfortunately my javascript foo is weak...

@zimbatm
Copy link
Member

zimbatm commented Aug 31, 2019

@blitz it's because the bower2nix resolver doesn't have the exact same heuristic as bower. Since bower and bower2nix are deprecated it's also not worth investing too much time into fixing those. It would be best if upstream could move all their dependencies to npm.

@zimbatm zimbatm merged commit ea3bae4 into NixOS:master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blitz @zimbatm