New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/mailman: postorius & hyperkitty support #67951
Conversation
I've been running this code on my server for a while now and consider it good enough(tm) to be useful to others. |
953a418
to
b129dc1
Compare
It is not a Python module that is usable otherwise. The files are specific
to mailman, and they're also situated in a folder that they are not
importable.
…On Wed, Sep 11, 2019, 09:32 Peter Simons ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/top-level/python-packages.nix
<#67951 (comment)>:
> @@ -715,6 +715,8 @@ in {
mailman = disabledIf (!isPy3k) (callPackage ../servers/mail/mailman/core.nix { });
+ mailman-web = disabledIf (!isPy3k) (callPackage ../servers/mail/mailman/web.nix { });
I don't know ... I am not convinced that defining that module exclusively
for NixOS is an improvement.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#67951?email_source=notifications&email_token=AAQHZ3Z4JGV5KEILTQ3Z6M3QJCNJDA5CNFSM4IS6AZT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCEKTHZA#discussion_r323096318>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQHZ35TBRCS6ESD7VUMGB3QJCNJDANCNFSM4IS6AZTQ>
.
|
Users of Nixpkgs can use that module to set up the Mailman Web UI outside of NixOS. |
Great, then it needs to become a proper package. Modules go in
site-packages and toPythonModule needs to be used so it identifies as a
Python module.
…On Wed, Sep 11, 2019, 09:49 Peter Simons ***@***.***> wrote:
It is not a Python module that is usable otherwise.
Users of Nixpkgs can use that module to set up the Mailman Web UI outside
of NixOS.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#67951?email_source=notifications&email_token=AAQHZ36ZKP23RCSGFUDDJITQJCPIJA5CNFSM4IS6AZT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6NTFTI#issuecomment-530264781>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAQHZ3YSXVF3GO44N2U3ZJ3QJCPIJANCNFSM4IS6AZTQ>
.
|
I am sorry, @FRidh. I am aware of the fact that you dedicate a lot of time and effort into maintaining the Python infrastructure. I also realize that you perform a lot of updates, make sure everything works, and are actively maintaining that part of Nixpkgs here on Github. I totally respect that and I'd like to use the occasion to say thank you for all those efforts for all those years, which have benefited me greatly. Having said that, the issue we are discussing here is a trivial minutiae that seems totally inconsequential. I don't understand where do you want to go with this. You seem to be pulling all kinds of rules and conventions out of thin air just for the sake of having something to criticize. |
@peti initially it did not make sense to me to have Right now, the issue is that the modules are not in a The Python packages is meant only for packages that provide importable packages and modules. That means the modules need to be in a Now, Django configuration is typically not put in a default |
OK. That makes sense. I'll make the necessary changes to |
…-shift Python library Suggested in NixOS#67951 (comment).
When mailman-web restarts, it removes the generated "static" directory. This breaks a currently running httpd process, which needs a re-start, too, to obtain a new handle for the newly generated path.
…-shift Python library Suggested in NixOS#67951 (comment). (cherry picked from commit 86f8895)
…-shift Python library Suggested in NixOS#67951 (comment).
A simple Apache configuration for running Postorious and Hyperkitty looks as follows:
[1] https://gitlab.com/mailman/hyperkitty/tree/master/example_project