New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Possible double path separator in FiosMakeFilename #7699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this would all be converted to std::string
, but that's a little further off...
I've been looking at this again, and I wonder if it's actually Also, checking for the UTF8-part is all well and good, but none of the other code supports it (plenty of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I dislike the trailing /
/ \
of directories, but I accept that some people like the distinction :)
Steps to reproduce: set a breakpoint after the FiosMakeFilename call, then save the game and check the path separator in front of the filename.