Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

java-service-wrapper: init at 3.5.41 #67824

Merged
merged 1 commit into from Nov 30, 2019
Merged

java-service-wrapper: init at 3.5.41 #67824

merged 1 commit into from Nov 30, 2019

Conversation

suhr
Copy link
Contributor

@suhr suhr commented Aug 31, 2019 •
edited

Motivation for this change

Provide java service wrapper for the i2p package (see #67641).

I don't know in which category I should put it, so I put it in misc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-in-distress/3604/6

tomfitzhenry
tomfitzhenry approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@tomfitzhenry tomfitzhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm unsure which directory this should be in. Consider upgrading to the latest version 3.5.41.

@suhr suhr changed the title java-service-wrapper: init at 3.5.35 java-service-wrapper: init at 3.5.41 Nov 19, 2019
c0bw3b
c0bw3b requested changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you locate it under pkgs/tools/system ? + move it accordingly in all-packages.nix
It's similar to a tool like undaemonize IMO and still better than top-level misc :)

pkgs/misc/java-service-wrapper/default.nix Outdated Show resolved Hide resolved
@suhr
Copy link
Contributor Author

suhr commented Nov 29, 2019

Done.

@c0bw3b c0bw3b merged commit daa7511 into NixOS:master Nov 30, 2019
@suhr suhr deleted the wrapper branch November 30, 2019 08:04
Luflosi added a commit to Luflosi/nixpkgs that referenced this pull request Sep 22, 2021
@Luflosi
i2p: get rid of duplicate Java Service Wrapper
5ffdc31 
The definition of Java Service Wrapper in i2p is identical to the java-service-wrapper package except that the latter also executes the test suite, which requires some extra dependencies.
The java-service-wrapper package was actually added in NixOS#67824 to move the definition from the i2p package into a separate package. While it was added as a separate package, it was never removed from i2p. This commit fixes that.
@Luflosi Luflosi mentioned this pull request Sep 22, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomfitzhenry tomfitzhenry tomfitzhenry approved these changes

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@suhr @nixos-discourse @tomfitzhenry @c0bw3b