Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ocaml_lwt: 4.1.0 -> 4.2.1 #67816

Merged
merged 1 commit into from Sep 6, 2019
Merged

ocamlPackages.ocaml_lwt: 4.1.0 -> 4.2.1 #67816

merged 1 commit into from Sep 6, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Aug 31, 2019

Motivation for this change

Ensures compatibility with OCaml 4.08

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
ocamlPackages.ocaml_lwt: 4.1.0 -> 4.2.1
f59acaa 
Ensures compatibility with OCaml 4.08
@vbgl
Copy link
Contributor Author

vbgl commented Aug 31, 2019

@GrahamcOfBorg build ocaml-ng.ocamlPackages_4_08.reason flow

@typetetris
Copy link
Contributor

Change of license seems fine: https://github.com/ocsigen/lwt/blob/4.2.1/LICENSE.md

@typetetris
Copy link
Contributor

nix-shell -p nix-review --run "nix-review wip" was successful on my machine too

@vbgl vbgl merged commit 22c5054 into NixOS:master Sep 6, 2019
@vbgl vbgl deleted the ocaml-lwt-4.2.1 branch September 6, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @typetetris