Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad: 0.9.4 -> 0.9.5 #67819

Merged
merged 1 commit into from
Aug 31, 2019
Merged

nomad: 0.9.4 -> 0.9.5 #67819

merged 1 commit into from
Aug 31, 2019
+18 −6

Conversation

endocrimes
Copy link
Member

Motivation for this change

This commit updates nomad from 0.9.4 to 0.9.5.

It also introduces the 'ui' build tag as it is incredibly useful when
working in development and production environments - and the assets are
included in release commits.

The method of including multiple tags, where some are optional was taken
from gitea as buildFlags was not handling nested quotes well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rushmorem @pradeepchhetri

Sorry, something went wrong.

@endocrimes
nomad: 0.9.4 -> 0.9.5
f6c47d0 
This commit updates nomad from 0.9.4 to 0.9.5.

It also introduces the 'ui' build tag as it is incredibly useful when
working in development and production environments - and the assets are
included in release commits.
@mmahut
Copy link
Member

mmahut commented Aug 31, 2019

@GrahamcOfBorg build nomad

@mmahut
Copy link
Member

mmahut commented Aug 31, 2019

@GrahamcOfBorg eval

@mmahut mmahut merged commit 1daa617 into NixOS:master Aug 31, 2019
@endocrimes endocrimes deleted the u-nomad branch September 1, 2019 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@endocrimes @mmahut