Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/crashplan #67818

Merged
merged 1 commit into from Sep 1, 2019
Merged

Remove/crashplan #67818

merged 1 commit into from Sep 1, 2019

Conversation

xvapx
Copy link
Contributor

@xvapx xvapx commented Aug 31, 2019

Motivation for this change

Crashplan home closed its service in October 2018.
Crashplan for small business has been broken since December 2018 with me as only maintainer, and only subscribed users can access the installer, which I'm no longer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sztupi @domenkozar @jerith666

@xvapx xvapx requested a review from infinisil as a code owner August 31, 2019 08:49
@aanderse aanderse mentioned this pull request Sep 1, 2019
Merged
10 tasks
@flokli
Copy link
Contributor

flokli commented Sep 1, 2019

pushed a squashed commit and release note.

aanderse
aanderse approved these changes Sep 1, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aanderse aanderse merged commit 3ee1adc into NixOS:master Sep 1, 2019
@xvapx xvapx deleted the remove/crashplan branch July 14, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@adisbladis adisbladis adisbladis requested changes

@aanderse aanderse aanderse approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xvapx @flokli @adisbladis @aanderse