Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rss2email: 3.9 -> 3.10 #67889

Merged
merged 1 commit into from Sep 9, 2019
Merged

rss2email: 3.9 -> 3.10 #67889

merged 1 commit into from Sep 9, 2019

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Sep 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Profpatsch

@GrahamcOfBorg build rss2email nixosTests.rss2email

@ofborg ofborg bot requested a review from jb55 September 1, 2019 14:50
@Ekleog
Copy link
Member Author

Ekleog commented Sep 1, 2019

@GrahamcOfBorg build nixosTests.rss2email

@Profpatsch
Copy link
Member

Whooo

@Profpatsch
Copy link
Member

@GrahamcOfBorg test rss2email

@Profpatsch
Copy link
Member

Do you want to fix the rss2email test before we merge? The dependent opensmpt test has a problem.

@jb55
Copy link
Contributor

jb55 commented Sep 3, 2019

@Profpatsch have you had any issues with rss2email sending multiple of the same email? I had to turn rss2email off awhile ago because of that

@Profpatsch
Copy link
Member

@Profpatsch have you had any issues with rss2email sending multiple of the same email? I had to turn rss2email off awhile ago because of that

Was it in 3.x? Some people didn’t like the 2 -> 3 rewrite because it introduced some bugs from what I heard.

@Ekleog
Copy link
Member Author

Ekleog commented Sep 7, 2019

@Profpatsch Being currently with no time to fix it, I'd say we can merge and see later. Intuitively it's due to the opensmtpd version upgrade which introduced another config file format, and should be pretty quick to fix, but I just don't have time right now.

And as the 19.09 cutoff is quite soon… maybe let's just merge by then? :)

@Ekleog
Copy link
Member Author

Ekleog commented Sep 7, 2019

@jb55 Got this neither with 3.9 nor with 3.10

@risicle
Copy link
Contributor

risicle commented Sep 7, 2019

nix-review checks out for me, macos 10.13.

@Profpatsch Profpatsch merged commit a80eef9 into NixOS:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@jb55 jb55 Awaiting requested review from jb55

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ekleog @Profpatsch @jb55 @risicle