Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxhexeditor: fix compilation #67992

Merged
merged 1 commit into from Sep 3, 2019
Merged

wxhexeditor: fix compilation #67992

merged 1 commit into from Sep 3, 2019

Conversation

marius851000
Copy link
Contributor

Motivation for this change

wxhexeditor failed to compile but I needed it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

No maintainer

@mmahut
Copy link
Member

mmahut commented Sep 3, 2019

@GrahamcOfBorg build wxhexeditor

@mmahut mmahut merged commit bf276a6 into NixOS:master Sep 3, 2019
@marius851000 marius851000 deleted the wxhexeditor2 branch September 3, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marius851000 @mmahut