Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qolibri: 2018-11-14 -> 2019-07-22 #67882

Merged
merged 2 commits into from Sep 10, 2019
Merged

qolibri: 2018-11-14 -> 2019-07-22 #67882

merged 2 commits into from Sep 10, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Sep 1, 2019

Motivation for this change

This update makes qolibri a lot more usable on hidpi displays.

mvf/qolibri@133a1c3...b58f983

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Built and tested on NixOS x86_64.

Notify maintainers

cc @

@ivan
Copy link
Member Author

ivan commented Sep 1, 2019

@GrahamcOfBorg build qolibri

@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
worldofpeace
worldofpeace approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works.

This should be backported because of the issue with qt wrappers.

@worldofpeace worldofpeace merged commit 70a0add into NixOS:master Sep 10, 2019
@worldofpeace worldofpeace modified the milestones: 20.03, 19.09 Sep 10, 2019
@ivan ivan mentioned this pull request Sep 10, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @worldofpeace @lheckemann