Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux/kernel: enable QoS and/or fair queueing #67855

Merged
merged 1 commit into from Sep 1, 2019
Merged

linux/kernel: enable QoS and/or fair queueing #67855

merged 1 commit into from Sep 1, 2019

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Sep 1, 2019

This allows to set queueing disciplines different than a simple fifo,
like fq_codel, which is the default in systemd since quite some time.

NET_SCHED is already set in the kernels x86_64_defconfig, but not on
arm/aarch64, so let's set it here.

Motivation for this change

nixosTests.systemd fails on aarch64 due to qdisc's not enabled in the kernel there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @samueldr

@flokli
linux/kernel: enable QoS and/or fair queueing
cb8d815 
This allows to set queueing disciplines different than a simple fifo,
like fq_codel, which is the default in systemd since quite some time.

NET_SCHED is already set in the kernels x86_64_defconfig, but not on
arm/aarch64, so let's set it here.
@flokli flokli requested a review from samueldr September 1, 2019 00:42
@flokli flokli mentioned this pull request Sep 1, 2019
Closed
10 tasks
@flokli
Copy link
Contributor Author

flokli commented Sep 1, 2019

@GrahamcOfBorg test systemd

@flokli
Copy link
Contributor Author

flokli commented Sep 1, 2019

@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.linux_4_14 pkgsCross.armv7l-hf-multiplatform.linux_4_19 pkgsCross.armv7l-hf-multiplatform.linux_5_2

@flokli flokli merged commit 829ff8a into NixOS:master Sep 1, 2019
@flokli flokli deleted the kernel-net-sched branch September 1, 2019 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @samueldr