Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcitx: use enchant2 #67856

Merged
merged 1 commit into from Sep 10, 2019
Merged

fcitx: use enchant2 #67856

merged 1 commit into from Sep 10, 2019

Conversation

averelld
Copy link
Contributor

@averelld averelld commented Sep 1, 2019 •
edited

Motivation for this change

Part of #38506.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build fcitx

worldofpeace
worldofpeace approved these changes Sep 1, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (arch already essentially does the same thing), didn't verify if it actually still works though.

@averelld
Copy link
Contributor Author

averelld commented Sep 1, 2019

I didn't do extensive testing, but I got word suggestions with ctrl-alt-h after putting dictionaries in .config/enchant/... in keyboard mode, so at least the library should work.

@gebner gebner merged commit 9c71e5f into NixOS:master Sep 10, 2019
@averelld averelld deleted the fcitx-use-enchant2 branch September 11, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@averelld @worldofpeace @gebner