Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/postgresql-wal-receiver: remove restart limit #67857

Merged
merged 1 commit into from Sep 23, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Sep 1, 2019

Motivation for this change

This removes the limit on restart attempts on the postgresql-wal-receiver service.
This limit isn't desirable on a backup service which should automatically restart after some long network disruption for instance.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

useful in case of network disruption
@pacien
Copy link
Contributor Author

pacien commented Sep 1, 2019

@GrahamcOfBorg test postgresql-wal-receiver

@pacien
Copy link
Contributor Author

pacien commented Sep 1, 2019

  • Tests are passing locally. (404 on ofborg?)

@pacien pacien marked this pull request as ready for review September 1, 2019 02:56
@pacien
Copy link
Contributor Author

pacien commented Sep 23, 2019

Ping @danbst

@danbst danbst merged commit 981177e into NixOS:master Sep 23, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 18, 2019
useful in case of network disruption

(cherry picked from commit 981177e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants