Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kustomize: simplify derivation #67954

Closed
wants to merge 1 commit into from
Closed

kustomize: simplify derivation #67954

wants to merge 1 commit into from

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Git revision can be obtained, we don't need to hard-code its value.
Related to #67615 , I had the same issue and I think my solution can be used here too.
I also update the build date to 1970-01-01T00:00:00Z instead of unknown. From my understanding, that's a common practice with nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Sep 2, 2019

We should avoid depending on .git in builds. In this case it seems to be easy to pass in what is needed.

@jlesquembre
kustomize: simplify derivation
e144d25 
Git revision can be obtained, no need to hardcode its value
@jlesquembre
Copy link
Member Author

@FRidh I didn't know about the issue with .git, it feels redundant to provide the git tag and the git revision. I also think that is easier to make mistakes during version updates, since you need to manually track the version and the revision.

But after your comment I found #8567, feel free to close this PR since it could cause errors

@zaninime
Copy link
Contributor

zaninime commented Sep 3, 2019

@jlesquembre you also have a performance penalty when using fetchgit vs. fetchFromGitHub. The second one eventually just fetches a .tar.gz with the code, while the first one has to pull the repo and resolve all the deltas, so it tends to get slower and slower, the longer the git history and the bigger the repo.

@FRidh FRidh closed this Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@carlosdagos carlosdagos Awaiting requested review from carlosdagos

@zaninime zaninime Awaiting requested review from zaninime

@vdemeester vdemeester Awaiting requested review from vdemeester

@periklis periklis Awaiting requested review from periklis

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlesquembre @FRidh @zaninime