Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 9334ce105abe
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 15f3e4eb814e
Choose a head ref
  • 4 commits
  • 5 files changed
  • 1 contributor

Commits on Sep 1, 2019

  1. nixos/redis: unbreak module

    The redis module currently fails to start up, most likely due to running
    a chown as non-root in preStart.
    
    While at it, I hardcoded it to use systemd's StateDirectory and
    DynamicUser to manage directory permissions, removed the unused
    appendOnlyFilename option, and the pidFile option.
    
    We properly tell redis now it's daemonized, and it'll use notify support
    to signal readiness.
    flokli committed Sep 1, 2019
    Copy the full SHA
    ff2fd6c View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    8680f72 View commit details
    Browse the repository at this point in the history
  3. nixos/redis: add test

    flokli committed Sep 1, 2019
    Copy the full SHA
    c00c4b1 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #67845 from flokli/redis-module

    nixos/redis: unbreak module, add test
    flokli committed Sep 1, 2019
    Copy the full SHA
    15f3e4e View commit details
    Browse the repository at this point in the history