thinkpad: minor trackpoint fixes #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most trackpoint users I know use the middle-button to have some scrolling functionality. So I think that for ThinkPads at least we should have this enabled by default if the trackpoint shall be used.
Newer ThinkPads have a new name for the Trackpoint - "TPPS/2 Elan TrackPoint". Having the "[...] IBM Trackpoint" as default caused some weird side-effects on my machine (e.g. stopped the trackpoint working after a suspend) with the wrong name. Although this is mentioned in the option's description[1], I think that this should be declared explicitly here. As soon, as we supported newer models as well[2], we should probably move this into its own common profile. [1] https://nixos.org/nixos/options.html#hardware.trackpoint.device [2] https://certification.ubuntu.com/catalog/component/input/5313/input%3ATPPS/2ElanTrackPoint/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the commit messages for further details :)