Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccls: 0.20190314.1 -> 0.20190823 #67832

Merged
merged 2 commits into from Sep 13, 2019
Merged

ccls: 0.20190314.1 -> 0.20190823 #67832

merged 2 commits into from Sep 13, 2019

Conversation

kira-bruneau
Copy link
Contributor

Motivation for this change

Upgrade ccls to the latest version. Noticed an improvement in code navigation & completion for large projects.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
      • Ubuntu 18.04
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 1228630608 → 1289047400 bytes
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

@ofborg ofborg bot requested a review from Mic92 August 31, 2019 14:38
@Mic92 Mic92 merged commit a4bea6d into NixOS:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kira-bruneau @Mic92