Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nut: fix build with openssl 1.1 #67906

Closed
wants to merge 1 commit into from
Closed

Conversation

ashkitten
Copy link
Contributor

fixes breakage from #22357

Motivation for this change

nut fails to build with openssl 1.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @nbp

@globin
Copy link
Member

globin commented Sep 2, 2019

Could you pull in the patches from networkupstools/nut#504 instead?

@ashkitten
Copy link
Contributor Author

@globin i can do that, yes. that would require using autoreconfHook which we don't currently use as this derivation uses a release tarball as src

@globin
Copy link
Member

globin commented Sep 12, 2019

Sure, that's fine obviously!

@lheckemann lheckemann added this to the 19.09 milestone Sep 12, 2019
@ashkitten ashkitten changed the title nut: specify openssl 1.0.2 nut: fix build with openssl 1.1 Sep 15, 2019
@ashkitten
Copy link
Contributor Author

@globin sorry it's taking so long to get back to this, i just pushed a change that uses the patch to work with openssl 1.1

@ashkitten
Copy link
Contributor Author

oops, it appears i was too slow and @aanderse took it upon themself to fix it by using nss instead of openssl. which approach do we want to take?

@aanderse
Copy link
Member

I've never used nut and know nothing about it. If you know anything about nut then you're in a much better position to determine which approach is better. Please feel free to replace my commit if yours is superior! 😄

@ashkitten
Copy link
Contributor Author

would love to get an opinion from @nbp if possible

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 6, 2019

Upstream configure.ac states:

Check for with-ssl, and --with-nss or --with-openssl
Only one can be enabled at a time, with a preference for OpenSSL
if both are available

@c0bw3b c0bw3b closed this in fd75f27 Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants