haskell-modules: update tensorflow for 1.14 #67952
Conversation
| cabal2nix . --subpath $f | ||
| echo ') {};' | ||
| done | ||
| echo }) | sed 's1src = ./.;1src = tensorflow-haskell-src;1' | nixfmt |
There was a problem hiding this comment.
It would be great if there was a separate updater script that basically did the above.
A bunch of other places in nixpkgs have an actual updater script that bumps versions and re-runs commands like this.
Having a script like this would make it much easier for other maintainers to keep the tensorflow stuff updated.
|
Where do the packages listed in |
| @@ -0,0 +1,310 @@ | |||
| { fetchFromGitHub }: | |||
There was a problem hiding this comment.
I was thinking that these tensorflow packages could probably go in the non-hackage-packages.nix file (since that is what they are), but if you also add an update script, it might just be easier to keep them in a separate file (so tensorflow-packages.nix as you currently have it).
|
@GrahamcOfBorg build haskellPackages.tensorflow haskellPackages.tensorflow-core-ops haskellPackages.tensorflow-logging haskellPackages.tensorflow-opgen haskellPackages.tensorflow-ops haskellPackages.tensorflow-proto haskellPackages.tensorflow-records haskellPackages.tensorflow-records-conduit haskellPackages.tensorflow-test |
ofborg
bot
added
8.has: clean-up
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
|
@peti It looks like the tensorflow libraries don't build with the latest I have confirmed that all the packages from this PR build correctly, but I imagine it might just be easier for us to wait until upstream merges in the above PR and makes a new release. When that happens we will be able to get rid of the stuff from this PR. |
|
I've asked upstream to do a release |
I've updated the tensorflow packages so they work with tensorflow 1.14.
Please let me know if there is a better way to put this in nixpkgs.
Notify maintainers
cc @basvandijk @peti