Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diesel-cli: init at 1.4.0 #67865

Merged
merged 1 commit into from Sep 1, 2019
Merged

diesel-cli: init at 1.4.0 #67865

merged 1 commit into from Sep 1, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Sep 1, 2019

Motivation for this change

Add diesel-cli to fix #67797.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

On NixOS x86_64 and macOS 10.14:

  • Tested with all *support options set to the default true.
  • Tested with mysqlSupport set to false.
  • Tested with postgresqlSupport set to false.
  • Tested with sqliteSupport set to false.
Notify maintainers

cc @

@ivan
Copy link
Member Author

ivan commented Sep 1, 2019

Diesel unfortunately has Rust's equivalent of -Werror, making the build fail without the patch to remove the deny(warnings. I don't know if there's a better way around this. Oddly, cargo install diesel_cli works with the newer rustc, but I don't know why.

@ivan
Copy link
Member Author

ivan commented Sep 1, 2019

@GrahamcOfBorg build diesel-cli

1 similar comment
@mmahut
Copy link
Member

mmahut commented Sep 1, 2019

@GrahamcOfBorg build diesel-cli

@mmahut mmahut merged commit 29e7629 into NixOS:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: diesel-cli
2 participants