Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notmuch: 0.28.4 -> 0.29.1 (and assorted fixes) #67844

Merged
merged 3 commits into from Sep 1, 2019
Merged

notmuch: 0.28.4 -> 0.29.1 (and assorted fixes) #67844

merged 3 commits into from Sep 1, 2019

Conversation

puckipedia
Copy link
Contributor

@puckipedia puckipedia commented Aug 31, 2019 •
edited

Motivation for this change

Updated to 0.29.1, and fixed a few relevant things. (like notmuch-emacs-mua being broken in some scenarios)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @flokli @the-kenny

@puckipedia puckipedia changed the title notmuch: 0.28.4 -> 0.29 (and assorted fixes) notmuch: 0.28.4 -> 0.29.1 (and assorted fixes) Aug 31, 2019
@ofborg ofborg bot requested review from the-kenny and flokli August 31, 2019 18:41
@flokli
Copy link
Contributor

flokli commented Sep 1, 2019

@puckipedia can you add a link to the release notes in the commit message bumping notmuch?

Can't comment on notmuch-emacs-mua, but otherwise looking good!

@puckipedia
notmuch: 0.28.4 -> 0.29.1
21fac08 
Release notes at https://notmuchmail.org/news/release-0.29/ and
 https://notmuchmail.org/news/release-0.29.1/
@puckipedia
notmuch: remove gpg substituteInPlace
abd8f6c 
As of 0.29, notmuch no longer has the gpg_path config, and instead
 uses the gmime default, so the substitute can be safely dropped.
@puckipedia
notmuch: fix notmuch-emacs-mua
bcc5431 
Before this patch, notmuch-emacs-mua would try to call emacs in PATH,
 which would obviously fail on systems with no emacs. This fixes that,
 while still keeping the capability to override your emacs' path.
@puckipedia
Copy link
Contributor Author

Yeah, I don't use emacs at all, but this was easy enough to fix (and necessary to tick off "Tested execution of all binary files" for me :p)

@flokli
Copy link
Contributor

flokli commented Sep 1, 2019

Alright :-)

@flokli flokli merged commit d4283f4 into NixOS:master Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-kenny the-kenny Awaiting requested review from the-kenny

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@puckipedia @flokli