Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-prefetch-github: 2.3 -> 2.3.1 #67944

Closed
wants to merge 3 commits into from
Closed

nix-prefetch-github: 2.3 -> 2.3.1 #67944

wants to merge 3 commits into from

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Sep 2, 2019 •
edited

Motivation for this change

There was new version released of this program upstream. All the changes upstream are backwards compatible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
Copy link
Member

FRidh commented Sep 2, 2019

Opened it twice. Closing this in favor of #67943.

@FRidh FRidh closed this Sep 2, 2019
@FRidh
Copy link
Member

FRidh commented Sep 2, 2019

Ah, nevermind, this is the release branch.

@FRidh FRidh reopened this Sep 2, 2019
@FRidh
Copy link
Member

FRidh commented Sep 2, 2019

I think it's better to cherry-pick -xe after the other one is submitted.

@seppeljordan
Copy link
Contributor Author

Hi, will do. Forgot about the cherry-picking rule.

@seppeljordan
nix-prefetch-github: 2.2 -> 2.3
dc3f694 
(cherry picked from commit 3c66428)
@seppeljordan
nix-prefetch-github: Remove propagatedBuildInputs `requests'
06c51d4 
`requests' is no longer required per setup.cfg

(cherry picked from commit 08dbc60)
@seppeljordan
nix-prefetch-github: 2.3 -> 2.3.1
1953a77 
(cherry picked from commit b97a20a)
@seppeljordan seppeljordan force-pushed the bump-nix-prefetch-github-backport branch from 2cb072b to 1953a77 Compare September 10, 2019 17:50
@seppeljordan
Copy link
Contributor Author

Hi, I backported the changes from master with git cherry-pick -xe .... Also tested everything again as described in the OP

@lheckemann lheckemann modified the milestone: 19.09 Sep 12, 2019
@seppeljordan
Copy link
Contributor Author

Okay, I don't want to see this anymore in my PR overview, closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seppeljordan @FRidh @lheckemann