Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan-headers, vulkan-tools: fix version #67841

Merged
merged 1 commit into from Sep 1, 2019
Merged

vulkan-headers, vulkan-tools: fix version #67841

merged 1 commit into from Sep 1, 2019

Conversation

ivan
Copy link
Member

@ivan ivan commented Aug 31, 2019 •
edited

Motivation for this change

This fixes an assertion error in vulkan-loader on version == vulkan-headers.version:

assertion failed at /nix/store/ca66sbxzxlxlfpb579nxxnw97z2ql1gv-source/pkgs/development/libraries/vulkan-loader/default.nix:8:1

The sha256 for vulkan-headers and vulkan-tools are unchanged because they were already set to the newer version. The correct versions were lost in the staging-next merge.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh @Ralith

@ivan
vulkan-headers, vulkan-tools: fix version
e540073 
This fixes an assertion error in vulkan-loader on version == vulkan-headers.version:

assertion failed at /nix/store/ca66sbxzxlxlfpb579nxxnw97z2ql1gv-source/pkgs/development/libraries/vulkan-loader/default.nix:8:1

The sha256 for vulkan-headers and vulkan-tools are unchanged because
they were already set to the newer version. The correct version was
lost in the staging-next merge.
@ivan
Copy link
Member Author

ivan commented Aug 31, 2019

@GrahamcOfBorg build vulkan-headers
@GrahamcOfBorg build vulkan-loader
@GrahamcOfBorg build vulkan-tools
@GrahamcOfBorg build vulkan-validation-layers

@ofborg ofborg bot requested a review from Ralith August 31, 2019 17:56
@ivan ivan mentioned this pull request Aug 31, 2019
Closed
10 tasks
@flokli flokli merged commit 0934064 into NixOS:master Sep 1, 2019
@flokli
Copy link
Contributor

flokli commented Sep 1, 2019

Thanks!

@ivan ivan mentioned this pull request Sep 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivan @flokli @Ralith