New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cryptpad: 3.0.0 -> 3.0.1 #67975
cryptpad: 3.0.0 -> 3.0.1 #67975
Conversation
Mmh. This triggers a weird npm issue even though none of the dependencies have actually changed from 3.0.0.
|
try with node2nix 1.7.0 |
37e2b0e
to
f2b3aba
Compare
@GrahamcOfBorg build cryptpad |
@GrahamcOfBorg build cryptpad (need to be known by ofborg to be able to do builds) |
The build currently fails because of the NPM package chainpad-server-3.0.4 fails to be fetched. This is weird, because NPM has this package.
|
f2b3aba
to
e5c55b9
Compare
As @tilpner said, you should probably try the newest node2nix version |
@infinisil @tilpner I'm using node2nix from the same nixpkgs revision and it generates the exact same output. So there is something else going on. |
Ah damn, the generate.sh script doesn't pin nixpkgs. Can you add this as a first commit which fixes this? diff --git a/pkgs/development/node-packages/generate.sh b/pkgs/development/node-packages/generate.sh
index dafbcb17f7e..6985462171b 100755
--- a/pkgs/development/node-packages/generate.sh
+++ b/pkgs/development/node-packages/generate.sh
@@ -1,5 +1,5 @@
#!/usr/bin/env nix-shell
-#! nix-shell -i bash -p nodePackages.node2nix
+#! nix-shell -i bash -p nodePackages.node2nix -I nixpkgs=../../..
set -eu -o pipefail |
Oh sorry I didn't read your message, you're using node2nix from the same nixpkgs version? What's |
e5c55b9
to
0ecf624
Compare
@infinisil Pinning nixpkgs in the shebang line actually did help. I previously changed Anyway, cryptpad 3.0.1 builds and runs now. What I still don't understand is that generate.sh (also with the now correctly pinned nixpkgs) updates the global node-env.nix. See here: blitz@d107b45 I've ignored these changes and it seems to be fine, but I guess this isn't intentional. And thanks for the handholding here. Much appreciated! |
@zimbatm I would appreciate another look here. Seems like I fixed my node2nix problems for now and everything works. |
Motivation for this change
Update to latest stable release.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @zimbatm