Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nim packages #67878

Closed
wants to merge 3 commits into from
Closed

Nim packages #67878

wants to merge 3 commits into from

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Sep 1, 2019

Motivation for this change

Repackage NImble packages using Nix.

This is yet another mkDerivation wrapper for yet another programing language and package manager.

A utility is provided at nix-generate-from-nimble for generating a JSON package description from Nimble metatdata and a skeleton default.nix file.

The first example package is an interpreter for the Spry language.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @peterhoeg @dom96

This split makes it possible to use the Nimble tools without adding the
Nim toolchain into an environment.
A Nixpkgs function for building Nimble packages and a script for
generating package expressions.
if pkg.web.len > 0:
echo(" website: " & pkg.web)

+func json*(pkg: Package): JsonNode =
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth contributing this upstream? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I tried to format the patch for a clean PR, but I'd like to tinker a bit more before I do that.

@ehmry
Copy link
Contributor Author

ehmry commented Sep 25, 2019

There are over a thousands PRs pending, not feasible in this repo.

@ehmry ehmry closed this Sep 25, 2019
@NickHu
Copy link
Contributor

NickHu commented Mar 1, 2020

Can I just ask what is going to happen to this PR? It looks fairly complete and it would be a shame to see all that work not get merged.

@NickHu NickHu mentioned this pull request Mar 1, 2020
10 tasks
@ehmry
Copy link
Contributor Author

ehmry commented Mar 1, 2020

@NickHu it was moved to a seperate flake-style repo, but is still a bit incomplete: https://github.com/nix-community/flake-nimble

@ehmry ehmry mentioned this pull request Sep 2, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants