Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.03] firefox: 68.0.2 -> 69.0 (and updated related packages) #67987

Merged
merged 9 commits into from Sep 3, 2019
Merged

[19.03] firefox: 68.0.2 -> 69.0 (and updated related packages) #67987

merged 9 commits into from Sep 3, 2019

Conversation

andir
Copy link
Member

@andir andir commented Sep 3, 2019 •
edited

Motivation for this change

Basically a backport of #67924
Surprisingly we do not need a newer rust version this time around…

Changelog: https://www.mozilla.org/en-US/firefox/69.0/releasenotes/
Security Fixes: https://www.mozilla.org/en-US/security/advisories/mfsa2019-25/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

andir and others added 9 commits September 2, 2019 20:27
@andir
nss: 3.44.1 -> 3.46
e87345d 
(cherry picked from commit 7b504b4)
@jonringer @andir
rust-cbindgen: 0.8.7 -> 0.9.0
f8bcf67 
(cherry picked from commit 3c85b71)
@andir
firefox: support building firefox 69
f5fcdb5 
(cherry picked from commit f3d3377)
@andir
firefox: 68.0.2 -> 69.0
02aad1f 
(cherry picked from commit 77fc386)
@alyssais @andir
firefox-bin.updateScript: always use up-to-date key
6648a03 
Otherwise we have to keep fetching a new key manually each time they
renew it.

(cherry picked from commit b0002f4)
@alyssais @andir
firefox-bin.updateScript: fix with GNUPGHOME
ba76e15 
If GNUPGHOME is set in the environment, it takes precedence over HOME,
so to avoid using a user's actual GNUPGHOME, we should override thiscc
instead of HOME.

(cherry picked from commit aee879c)
@andir
firefox-bin: 68.0.2 -> 69.0
84e1bbb
@andir
firefox-beta-bin: 69.0b14 -> 69.0b16
9c13037
@andir
firefox-devedition-bin: 68.0b12 -> 70.0b2
bad6bf2
@ofborg ofborg bot requested review from jtojnar and edolstra September 3, 2019 07:11
andir added a commit that referenced this pull request Sep 3, 2019
@andir
Merge nss bump from #67987 into staging-19.03
0de9229
@andir
Copy link
Member Author

andir commented Sep 3, 2019

The build in staging doesn't look bad. I'll go ahead and merge this in.

@andir andir merged commit 56b8427 into NixOS:release-19.03 Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @jonringer @alyssais