Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pastel: init at 0.5.3 #67960

Closed
wants to merge 1 commit into from
Closed

pastel: init at 0.5.3 #67960

wants to merge 1 commit into from

Conversation

mtrsk
Copy link
Member

@mtrsk mtrsk commented Sep 2, 2019

Motivation for this change

Adds sharkdp/pastel to nixpkgs.

Things done

This is my fist derivation/packaging sent to nixpkgs, any feedback is always welcome.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

{ stdenv, fetchFromGitHub, rustPlatform }:

rustPlatform.buildRustPackage rec {
name = "pastel-rs";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "pastel-rs";

The name will automatically be set by the pname and version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Also, should the name just remain the same as in pname then at the top-level packages (just pastel)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it should just be pastel. https://repology.org/project/pastel/versions

description = "A rust command-line tool to generate, analyze, convert and manipulate colors";
homepage = "https://github.com/sharkdp/pastel";
license = with licenses; [ mit apache ];
maintainers = [ maintainers.mtrsk ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making yourself a maintainer! This currently isn't building though because mtrsk is currently not a maintainer on the master branch. Could you add yourself to maintainers/maintainer-list.nix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the addition to maintainer-list.nix be in a separate commit which happens before the current one and titled maintainers: add wtrsk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtrsk Could you rewrite the git history so your pull request has only two commits? That way, there is only one "init" commit and all your commits will safely build


cargoSha256 = "05yvlm7z3zfn8qd8nb9zpch9xsfzidrpyrgg2vij3h3q095mdm66";

meta = with stdenv.lib; {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could have lib as an argument instead of stdenv at the top and use with lib; here

@mtrsk mtrsk changed the title pastel-rs: init at v0.5.3 pastel: init at v0.5.3 Sep 3, 2019
@worldofpeace worldofpeace changed the title pastel: init at v0.5.3 pastel: init at 0.5.3 Sep 3, 2019
@worldofpeace
Copy link
Contributor

Please have you final commit msg be what I've edited the title to @mtrsk.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (Although commits should be squashed, see below)
executable seems to work
leaf package

commits:

maintainers: add mtrsk
pastel: init at 0.5.3

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pastel

@mtrsk mtrsk requested a review from ryantm September 6, 2019 19:16
@dtzWill dtzWill mentioned this pull request Sep 23, 2019
10 tasks
@mtrsk mtrsk closed this Sep 25, 2019
@mtrsk mtrsk deleted the pastel-rs_init-0.5.3 branch September 25, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants