New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pastel: init at 0.5.3 #67960
pastel: init at 0.5.3 #67960
Conversation
{ stdenv, fetchFromGitHub, rustPlatform }: | ||
|
||
rustPlatform.buildRustPackage rec { | ||
name = "pastel-rs"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "pastel-rs"; |
The name will automatically be set by the pname and version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Also, should the name just remain the same as in pname
then at the top-level
packages (just pastel
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it should just be pastel
. https://repology.org/project/pastel/versions
description = "A rust command-line tool to generate, analyze, convert and manipulate colors"; | ||
homepage = "https://github.com/sharkdp/pastel"; | ||
license = with licenses; [ mit apache ]; | ||
maintainers = [ maintainers.mtrsk ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making yourself a maintainer! This currently isn't building though because mtrsk is currently not a maintainer on the master branch. Could you add yourself to maintainers/maintainer-list.nix
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the addition to maintainer-list.nix
be in a separate commit which happens before the current one and titled maintainers: add wtrsk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mtrsk Could you rewrite the git history so your pull request has only two commits? That way, there is only one "init" commit and all your commits will safely build
|
||
cargoSha256 = "05yvlm7z3zfn8qd8nb9zpch9xsfzidrpyrgg2vij3h3q095mdm66"; | ||
|
||
meta = with stdenv.lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could have lib
as an argument instead of stdenv
at the top and use with lib;
here
Please have you final commit msg be what I've edited the title to @mtrsk. |
21e0713
to
85a8ffa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nix-review
passes on NixOS
diff LGTM (Although commits should be squashed, see below)
executable seems to work
leaf package
commits:
maintainers: add mtrsk
pastel: init at 0.5.3
@GrahamcOfBorg build pastel |
85a8ffa
to
ca1f805
Compare
Motivation for this change
Adds sharkdp/pastel to nixpkgs.
Things done
This is my fist derivation/packaging sent to
nixpkgs
, any feedback is always welcome.sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @