Make the HoloLens UI look better #24126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Does the browser still recognize voice commands like "back" and "refresh" with these changes? |
|
☔ The latest upstream changes (presumably #24125) made this pull request unmergeable. Please resolve the merge conflicts. |
Nope. I'll see how to fix that. |
Now it does. |
|
Erf, pushed too many changes. |
|
r? @jdm |
|
@bors-servo r+ |
|
📌 Commit 19d9616 has been approved by |
highfive
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Sep 11, 2019
Make the HoloLens UI look better Throbber, icons, tooltips, alignment, etc... Based on top of #24125 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24126) <!-- Reviewable:end -->
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
bors-servo
pushed a commit
that referenced
this pull request
Sep 11, 2019
Make the HoloLens UI look better Throbber, icons, tooltips, alignment, etc... Based on top of #24125 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24126) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
bors-servo
pushed a commit
that referenced
this pull request
Sep 11, 2019
Make the HoloLens UI look better Throbber, icons, tooltips, alignment, etc... Based on top of #24125 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24126) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
💔 Test failed - status-taskcluster |
highfive
added
S-tests-failed
|
@bors-servo retry
|
|
💣 Failed to start rebuilding: |
bors-servo
pushed a commit
that referenced
this pull request
Sep 12, 2019
Make the HoloLens UI look better Throbber, icons, tooltips, alignment, etc... Based on top of #24125 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24126) <!-- Reviewable:end -->
highfive
added
S-awaiting-merge
|
☀️ Test successful - linux-rel-css, linux-rel-wpt, status-taskcluster |
highfive
removed
the
S-awaiting-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throbber, icons, tooltips, alignment, etc...
Based on top of #24125
This change is