Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.dash-to-panel: 19 -> 23 #67967

Merged
merged 1 commit into from Sep 3, 2019
Merged

gnomeExtensions.dash-to-panel: 19 -> 23 #67967

merged 1 commit into from Sep 3, 2019

Conversation

dkabot
Copy link
Member

@dkabot dkabot commented Sep 2, 2019

Motivation for this change

It seems that traditionally, dash-to-panel is only updated in nixpkgs alongside GNOME itself, but v20 (and anything past that) is a major upgrade and may be worth pulling in on its own.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mounium

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Sep 2, 2019
@ryantm ryantm requested a review from jtojnar September 2, 2019 22:19
@jtojnar
Copy link
Contributor

jtojnar commented Sep 2, 2019

Yeah, the extensions are always pain to test since I cannot just run an executable from /nix/store like with most applications – I need to install them, enable them and restart GNOME Shell to make sure they work. For that reason, I update the extensions I do not use only twice a year when new GNOME is released.

The changes look okay:

jtojnar
jtojnar approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it works.

@jtojnar
Copy link
Contributor

jtojnar commented Sep 3, 2019

Thanks.

@jtojnar jtojnar merged commit c3c020c into NixOS:master Sep 3, 2019
@dkabot dkabot deleted the dash-to-panel_v23 branch September 3, 2019 02:10
@dkabot
Copy link
Member Author

dkabot commented Sep 3, 2019

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkabot @jtojnar