Motivation for this change

sd-image.nix does not import clone-config.nix, so the installer.cloneConfig option does not exist when sd-image.nix is imported on its own. The ability to do that is very useful for creating SD images for arbitrary NixOS configurations, rather than a generic installer image. Here is how I use this capability: https://github.com/lopsided98/nixos-config/blob/master/modules/local/machine/raspberry-pi.nix

In the future, we might want to create a installer-sd-image.nix that imports installation-device.nix and sets cloneConfig, but for now I just moved the cloneConfig setting to each SD image module.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

Notify maintainers

cc @flokli @samueldr