Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caffeine-ng: use python3 and some other improvements #67894

Merged
merged 4 commits into from Sep 5, 2019
Merged

caffeine-ng: use python3 and some other improvements #67894

merged 4 commits into from Sep 5, 2019

Conversation

marzipankaiser
Copy link
Contributor

@marzipankaiser marzipankaiser commented Sep 1, 2019 •
edited

Motivation for this change

Using python3 is recommended by upstream, using python2 is not officially supported.
Edit: After the review by @flokli, some other improvements were incorporated (cleaned up dependencies)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marzipankaiser
caffeine-ng: do not run tests
fc78d8e 
There are no tests anyway. Not finding the tests results in build
failures if using Python 3.
@symphorien
Copy link
Member

Is there any reason to use python36Packages instead of python3Packages ?

@marzipankaiser
caffeine-ng: use python3
85c084d 
Using python3 is recommended by upstream.
@marzipankaiser
Copy link
Contributor Author

marzipankaiser commented Sep 1, 2019 •
edited

Not in particular, except my ignorance. Changed. Thanks.

@marzipankaiser marzipankaiser changed the title caffeine-ng: use python3.6 caffeine-ng: use python3 Sep 1, 2019
@wd15
Copy link
Contributor

wd15 commented Sep 3, 2019

Result of nix-review pr 67894 1

1 package was built:
  • caffeine-ng

@marzipankaiser
caffeine-ng: move setuptools_scm dependency to buildInputs
d64cdba 
setuptools_scm is only needed during build, not whilst using the package.
@marzipankaiser marzipankaiser changed the title caffeine-ng: use python3 caffeine-ng: use python3 and some other improvements Sep 5, 2019
@flokli
Copy link
Contributor

flokli commented Sep 5, 2019

Thanks!

@flokli flokli merged commit 0213ccf into NixOS:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marzipankaiser @symphorien @wd15 @flokli