add label for exactly 1 rebuild #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a good idea. I'd like to continue applying the |
It is fundamentally different to review a leaf package with no other reverse dependencies in Nixpkgs and one that has at least one reverse dependency, so make those separate labels.
|
@grahamc Okay, done, and I added the proper tests now. Also, your suggestion makes this change will be backward compatible, so that's nice! By the way, I didn't commit this but in order to build this I had to add the
If you want me to add those |
|
Please do add the annotations :)
…On Thu, Sep 26, 2019, at 12:52 AM, Ryan Mulligan wrote:
@grahamc <https://github.com/grahamc> Okay, done, and I added the proper tests now. Also, your suggestion makes this change will be backward compatible, so that's nice!
By the way, I didn't commit this but in order to build this I had to add the `dyn` annotation in 7 places because of this error:
`error: trait objects without an explicit `dyn` are deprecated`
If you want me to add those `dyn` annotations to this branch, I can.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#395?email_source=notifications&email_token=AAASXLFYWQ3J2O56PE2XWJLQLQ5XRA5CNFSM4ITBHPA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7UI5DA#issuecomment-535334540>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAASXLGOPMLE7ANAK77CZNLQLQ5XRANCNFSM4ITBHPAQ>.
|
|
@grahamc Added. |
|
@grahamc Do you need anything else from me to merge this? |
|
Even though the CI is failing, I think this is ready to go, because the CI errors seem unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is fundamentally different to review a leaf package with no other reverse dependencies in Nixpkgs and one that has at least one reverse dependency, so make those separate labels.
I expect rolling this out is going to have to coincide with updating the labels and adding the new labels.